chore: add top-level .editorconfig, copied from the ditto repository#95
chore: add top-level .editorconfig, copied from the ditto repository#95kristopherjohnson wants to merge 5 commits intomainfrom
.editorconfig, copied from the ditto repository#95Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a top-level .editorconfig file to establish consistent code formatting standards across the repository. The configuration is copied from the ditto repository to maintain consistency between projects.
- Adds universal formatting rules for line endings, trailing whitespace, and final newlines
- Configures language-specific indentation for JavaScript/TypeScript (2 spaces) and shell scripts (4 spaces)
- Sets up ignore patterns for generated directories and dependencies
.editorconfig
Outdated
| [{.cxx,gradlew*,node_modules}] | ||
| ignore = true | ||
|
|
||
| [target/**] | ||
| ignore = true | ||
|
|
||
| [.direnv/**] | ||
| ignore = true | ||
|
|
||
| [**/Pods/**] | ||
| ignore = true | ||
|
|
||
| [**/node_modules/**] | ||
| ignore = true | ||
|
|
There was a problem hiding this comment.
The ignore property is not a valid EditorConfig property. EditorConfig doesn't support an ignore directive.
| [{.cxx,gradlew*,node_modules}] | |
| ignore = true | |
| [target/**] | |
| ignore = true | |
| [.direnv/**] | |
| ignore = true | |
| [**/Pods/**] | |
| ignore = true | |
| [**/node_modules/**] | |
| ignore = true |
.editorconfig
Outdated
| [{.cxx,gradlew*,node_modules}] | ||
| ignore = true | ||
|
|
||
| [target/**] | ||
| ignore = true | ||
|
|
||
| [.direnv/**] | ||
| ignore = true | ||
|
|
||
| [**/Pods/**] | ||
| ignore = true | ||
|
|
||
| [**/node_modules/**] | ||
| ignore = true | ||
|
|
There was a problem hiding this comment.
The ignore property is not a valid EditorConfig property. EditorConfig doesn't support an ignore directive.
| [{.cxx,gradlew*,node_modules}] | |
| ignore = true | |
| [target/**] | |
| ignore = true | |
| [.direnv/**] | |
| ignore = true | |
| [**/Pods/**] | |
| ignore = true | |
| [**/node_modules/**] | |
| ignore = true |
.editorconfig
Outdated
| [{.cxx,gradlew*,node_modules}] | ||
| ignore = true | ||
|
|
||
| [target/**] | ||
| ignore = true | ||
|
|
||
| [.direnv/**] | ||
| ignore = true | ||
|
|
||
| [**/Pods/**] | ||
| ignore = true | ||
|
|
||
| [**/node_modules/**] | ||
| ignore = true | ||
|
|
There was a problem hiding this comment.
The ignore property is not a valid EditorConfig property. EditorConfig doesn't support an ignore directive.
| [{.cxx,gradlew*,node_modules}] | |
| ignore = true | |
| [target/**] | |
| ignore = true | |
| [.direnv/**] | |
| ignore = true | |
| [**/Pods/**] | |
| ignore = true | |
| [**/node_modules/**] | |
| ignore = true |
.editorconfig
Outdated
| [{.cxx,gradlew*,node_modules}] | ||
| ignore = true | ||
|
|
||
| [target/**] | ||
| ignore = true | ||
|
|
||
| [.direnv/**] | ||
| ignore = true | ||
|
|
||
| [**/Pods/**] | ||
| ignore = true | ||
|
|
||
| [**/node_modules/**] | ||
| ignore = true | ||
|
|
There was a problem hiding this comment.
The ignore property is not a valid EditorConfig property. EditorConfig doesn't support an ignore directive.
| [{.cxx,gradlew*,node_modules}] | |
| ignore = true | |
| [target/**] | |
| ignore = true | |
| [.direnv/**] | |
| ignore = true | |
| [**/Pods/**] | |
| ignore = true | |
| [**/node_modules/**] | |
| ignore = true |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…le.kts Reverted the Ditto C++ SDK dependency from local AAR file back to the published Maven artifact version 4.11.0. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
pvditto
left a comment
pvditto
left a comment
There was a problem hiding this comment.
LGTM, I don't think the ignore section will do anything though.
| # Exclude files and directories by ensuring they are not matched by any section | ||
| # Files like .cxx, gradlew*, and node_modules are not explicitly matched in this file. | ||
|
|
||
| # Exclude target directory | ||
| [!target/**] | ||
|
|
||
| # Exclude .direnv directory | ||
| [!.direnv/**] | ||
|
|
||
| # Exclude Pods directory | ||
| [!**/Pods/**] | ||
|
|
||
| # Exclude node_modules directory | ||
| [!**/node_modules/**] |
There was a problem hiding this comment.
I don't think .editorconfig supports ignoring paths, these lines define empty rulesets applying to any path that does not match e.g. target/**.
There was a problem hiding this comment.
adding ignore = true under a [heading] will tell editors to ignore files under a matching path.
There was a problem hiding this comment.
Now I'm seeing that ignore is not a valid EditorConfig property. The ignore = true syntax is supported by shfmt, which is what we're using to lint and format shell scripts in the monorepo.
One SO answer suggests setting all properties to unset to disable validation.
| [!**/Pods/**] | ||
|
|
||
| # Exclude node_modules directory | ||
| [!**/node_modules/**] |
There was a problem hiding this comment.
| [!**/node_modules/**] | |
| [**/node_modules/**] | |
| ignore = true |
3 participants
Adds an
.editorconfigfile to the Quickstart repo, which matches the configuration used in thedittorepo.This will help maintain consistent formatting for everyone who contributes to this repo.