Allowed login bypass for local development #48
Conversation
|
@lfgcampos is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
makes sense - i had considered doing it but was being lazy. i think just make sure we dont have any bypasses (i agree w/ the cursor flag here - only needed in dev) |
sorry for the long time, that should now be fixed =) |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| // Redirect to home if auth is bypassed (local development) | ||
| const isAuthBypassed = | ||
| process.env.NODE_ENV !== 'production' && process.env.AUTH_BYPASS_LOCAL === 'true'; |
There was a problem hiding this comment.
Auth bypass check duplicated in three separate files
Low Severity
The isAuthBypassed expression (process.env.NODE_ENV !== 'production' && process.env.AUTH_BYPASS_LOCAL === 'true') is duplicated verbatim in three files: src/lib/auth.ts, src/proxy.ts, and src/app/sign-in/layout.tsx. If the bypass condition ever needs to change (e.g., adding an additional safety check), all three must be updated in lockstep — easy to miss. Extracting it into a small dependency-free module (e.g., src/lib/dev-config.ts) would let all three import the same value, including the Edge-runtime proxy.ts.
Additional Locations (2)
2 participants
Should fix #45