Investigate source file upload duplication#2977
Draft
szokeasaurusrex wants to merge 1 commit intomasterfrom
Draft
Investigate source file upload duplication#2977szokeasaurusrex wants to merge 1 commit intomasterfrom
szokeasaurusrex wants to merge 1 commit intomasterfrom
Conversation
Investigate whether sentry-cli uploads source files twice during sourcemap upload when sources are embedded in sourcesContent. Key findings: - Duplication CAN occur when original .js files exist in upload path - Modern build tools typically avoid this by separating dist/ from src/ - TypeScript/JSX sources are not affected (different extensions) - Current behavior is technically correct but could be optimized The investigation confirms the colleague's observation is valid for specific build configurations where both original JS sources and sourcemaps with sourcesContent exist in the same upload directory.
|
Cursor Agent can help with this pull request. Just |
Contributor
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
### Features
- Investigate source file upload duplication ([#2977](https://github.com/getsentry/sentry-cli/pull/2977))If none of the above apply, you can opt out of this check by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
investigation.mddetailing whethersentry-clican upload source files twice during sourcemap uploads. The investigation concludes that duplication can occur when original.jssource files are present in the upload directory alongside sourcemaps that embed theirsourcesContent. It also outlines scenarios where this happens and where it doesn't, along with technical details and potential solutions.Issues