-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(node-core): Add node-core/light #18502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
1687319 to
773cb0a
Compare
5f3ebcb to
f5bdfc9
Compare
size-limit report 📦
|
748eb5f to
fdb1403
Compare
Codecov Results 📊Generated by Codecov Action |
| "dependencies": { | ||
| "@apm-js-collab/tracing-hooks": "^0.3.1", | ||
| "@sentry/core": "10.38.0", | ||
| "@sentry/opentelemetry": "10.38.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, this is a breaking change. That being said, the only place where we document node-core is in the README and the README already advised users to install @sentry/opentelemetry so... maaaybe this is ok?
sentry-javascript/packages/node-core/README.md
Lines 23 to 30 in 356776c
| ## Installation | |
| ```bash | |
| npm install @sentry/node-core @sentry/opentelemetry @opentelemetry/api @opentelemetry/core @opentelemetry/context-async-hooks @opentelemetry/instrumentation @opentelemetry/resources @opentelemetry/sdk-trace-base @opentelemetry/semantic-conventions | |
| # Or yarn | |
| yarn add @sentry/node-core @sentry/opentelemetry @opentelemetry/api @opentelemetry/core @opentelemetry/context-async-hooks @opentelemetry/instrumentation @opentelemetry/resources @opentelemetry/sdk-trace-base @opentelemetry/semantic-conventions | |
| ``` |
fdb1403 to
da1124d
Compare
This PR adds a lightweight version of the node-core SDK that doesn't include nor requires OpenTelemetry dependencies. It provides a basic error-tracking SDK with support for request isolation via AsyncLocalStorage and basic tracing abilities
via our
Sentry.startSpan*apis.Request isolation requires Node 22.12.0+. On lower Node versions, manual wrapping via
Sentry.withIsolationScopeis necessary to isolate requests.