fix(core): Prevent infinite recursion when event processor throws #19110
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logaretm
force-pushed
the
awad/js-1606-event-processor-errors-cause-silent-event-loss-via-infinite
branch
from
f0cde98 to
f420e5a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug where event processors that throw on all events cause infinite recursion, resulting in silent event loss. The fix skips event processors for internal exception events (marked with hint.data.__sentry__ = true) to break the recursion cycle, similar to how beforeSend is already skipped for these events.
Changes:
- Modified
prepareEvent.tsto detect internal exceptions and skip event processors for them - Added a test to verify that a client-level processor that always throws only runs once
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/utils/prepareEvent.ts | Added logic to skip event processors for internal exceptions (marked with __sentry__ flag) to prevent infinite recursion |
| packages/core/test/lib/client.test.ts | Added test to verify that a processor throwing on all events doesn't cause infinite recursion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Codecov Results 📊✅ 146 passed | Total: 146 | Pass Rate: 100% | Execution Time: 6m 9s All tests are passing successfully. Generated by Codecov Action |
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
logaretm
deleted the
awad/js-1606-event-processor-errors-cause-silent-event-loss-via-infinite
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an event processor throws an error, the SDK calls
captureExceptionto report it withhint.data.__sentry__ = true. However, this new event still ran through all event processors, causing infinite recursion if the processor throws on every event.I'm not sure what's the best way to resolve this, I had a couple of ideas:
prepareEvent().I went with (2) because it is consistent with how
beforeSendis already skipped for these events. The processor error is still captured and sent to Sentry, but it bypasses event processors to break the recursion.Fixes #19108