fix(core): Respect event.event_id in scope.captureEvent return value #19113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug while working on the JavaScript SDK integration in Sentry for Godot (it's a game engine SDK).
When you call
Sentry.captureEvent({ event_id: "<custom-event-id>" }), theevent_idyou provide IS actually used when the event is processed and sent to Sentry (becauseprepareEvent.tscorrectly checksevent.event_idfirst). However, the return value fromcaptureEvent()is wrong because:In
sentry-javascript/packages/core/src/scope.ts:sentry-javascript/packages/core/src/scope.ts
Line 758 in 170b6f8
This only checks
hint?.event_id, notevent.event_id. So while your suppliedevent_idgets sent to Sentry correctly, the function returns a newly generated UUID.Closes #issue_link_here