[Monolog] Only skip real exceptions#1781
Draft
wjzijderveld wants to merge 3 commits intogetsentry:5.xfrom
Draft
Conversation
9eb2bbe to
4456894
Compare
cleptric
reviewed
Sep 30, 2024
Member
cleptric
left a comment
There was a problem hiding this comment.
Looks like something for the next major. Not keen of changing this behavior in a minor.
Author
|
I can understand that, in a weird way it's a BC break. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding a
exceptionproperty to the monolog context, it would get skipped regardless if the exception was used as hint or not.