-
Notifications
You must be signed in to change notification settings - Fork 580
fix: Fix list attribute type #5417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Span Streaming
Other
Bug Fixes 🐛Google Genai
Span Streaming
Other
Internal Changes 🔧Fastmcp
Mcp
Other
🤖 This preview updates automatically when you update the PR. |
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 8.64s All tests are passing successfully. ❌ Patch coverage is 0.00%. Project has 13632 uncovered lines. Files with missing lines (180)
Generated by Codecov Action |
f04b78a to
ba9df31
Compare
|
The lint failure is unrelated (ruff is complaining about a file I didn't touch), will fix that separately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
List attributes should be sent over the wire with
type: arrayinstead of specializedinteger[],string[]etc. types.We might support non-homogenous arrays in the future.