Include span status in HTTP client spans based on the response's status#2650
Open
cjcormack wants to merge 2 commits intogetsentry:masterfrom
Open
Include span status in HTTP client spans based on the response's status#2650cjcormack wants to merge 2 commits intogetsentry:masterfrom
cjcormack wants to merge 2 commits intogetsentry:masterfrom
Conversation
… spans get their status set correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates
Utils::HttpTracingso that it usesset_http_statusso that the spans include the status. Without this change, graphs such asfailure_rate()for spans for HTTP requests, for example, with the:faradaypatch. Other usages within sentry-ruby look to already be correct.