Make Comparer.is_match property work ...#28
Closed
webartifex wants to merge 1 commit intogianchub:mainfrom
Closed
Conversation
... for an `errors` dictionary full of
inspectors without any errors, for example:
```
{
'columns': {},
'primary_keys': {},
'foreign_keys': {},
'indexes': {},
'unique_constraints': {},
'check_constraints': {},
}
```
Author
|
The above example show an example where the two databases compared are identical. The current I did not check when this bug was introduced (must be v1 though) nor did I run the test suite. So, maybe some test cases need adjustment too. |
Owner
|
Much appreciated @webartifex :) |
Author
|
Your solution is way nicer :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... for an
errorsdictionary full ofinspectors without any errors, for example: