Modify progress reset to redownload base files #38
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds functionality to re-download base files during progress reset operations to ensure that files like answers.txt are properly reset to their original state, addressing issue #240.
Changes:
- Added import for
Pathfrompathlibmodule - Implemented base files re-download logic within the progress reset flow
- Added directory creation and binary file type detection for downloaded base files
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jovnc
commented
Jan 17, 2026
| with ExercisesRepo() as repo: | ||
| formatted_exercise_name = exercise_config.formatted_exercise_name | ||
|
|
||
| if len(exercise_config.base_files) > 0: |
Collaborator
Author
There was a problem hiding this comment.
Even repo_type ignore may have base files we want to restore to original state
SAN-MUYUN
reviewed
Jan 26, 2026
SAN-MUYUN
left a comment
SAN-MUYUN
left a comment
There was a problem hiding this comment.
Thanks for your work! Tested and works, LGTM 👍
| is_binary, | ||
| ) | ||
|
|
||
| if exercise_config.exercise_repo.repo_type != "ignore": |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes git-mastery/exercises#240
Currently, we use
base-filesforanswers.txtfile, but we don't reset these base files inprogress reset. This missing behaviour leads to unexpected results, where students expectprogress resetto reset theiranswers.txtfile, but it is not reset, ie. it is not an entirely clean state as students would expect.This change adds an additional step in
progress resetto re-download base files as well to ensure comprehensiveness inprogress reset, to ensure that the exercise is reset fully.