Open
Conversation
dscho
requested changes
Feb 17, 2026
Member
dscho
left a comment
dscho
left a comment
There was a problem hiding this comment.
This looks great!
Just a few things that I'd like to see fixed before merging.
| <small>... one iteration at a time... </small> | ||
| {{- end -}} | ||
| <div class="banner"> | ||
| {{- if eq .Kind "home" }} |
Member
Comment on lines
+30
to
+45
| pre { | ||
| background-color: rgb(247, 243, 239); | ||
| border: 1px solid #c5bbb0; | ||
| border-radius: 0.5em; | ||
| padding: 1em; | ||
| overflow-x: auto; | ||
| } | ||
| code { | ||
| background-color: rgb(247, 243, 239); | ||
| padding: 0.1em 0.3em; | ||
| border-radius: 0.25em; | ||
| } | ||
| pre code { | ||
| background-color: transparent; | ||
| padding: 0; | ||
| } |
Member
There was a problem hiding this comment.
I would really like to learn from this. To that end, would you mind extending the commit message quite a bit? I'd like it more in line with https://github.blog/2022-06-30-write-better-commits-build-better-projects/, in particular with a strong focus on this part:
| What you’re doing | Why you’re doing it | |
|---|---|---|
| High-level (strategic) | Intent (what does this accomplish?) | Context (why does the code do what it does now?) |
| Low-level (tactical) | Implementation (what did you do to accomplish your goal?) | Justification (why is this change being made?) |
| background-image: linear-gradient(#d7cdc0ff, #fdf7f6ff); | ||
| margin-right: 10%; | ||
| margin-left: 10%; | ||
| overflow-wrap: break-word; |
Member
There was a problem hiding this comment.
Is this a fixup for dad29bc that would want to be squashed into that commit instead of living on its own? Also, the commit message does not help me understand the problem, the context, and why the proposed solution is the best way to solve the problem. I would love it to help me, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #19 and makes the site (all 3 pages) mobile responsive without changing the intended UI on desktop. No content has been edited.
A live demo can be tested here https://gitgitgadget.ritovision.com
What has changed
Before and After Screenshots
Homepage - BEFORE
Homepage - AFTER
Architecture - BEFORE
Architecture - AFTER
Reply-to-this - BEFORE
Reply-to-this - AFTER
Desktop Homepage - BEFORE
Desktop Homepage - AFTER
Notice the layout still looks and scales the same