Conversation
This PR updates the “Set results output” step so data from previous steps is directly interpolated into the JS script, rather than passed via environment variables. This prevents “Argument list too long” errors (and resulting workflow failures). Under the hood, `actions/github-script` was doing something like this: ```shell FILINGS='/** A huge JSON blob **/' FIXINGS='/** A huge JSON blob **/' node tmp/script.js ``` Depending on the size of `FILINGS` and `FIXINGS`, this could exceed a system’s `ARG_MAX` (https://www.in-ulm.de/~mascheck/various/argmax/ is a good explainer). After removing the environment variables, the argument list length is much shorter, so the error is avoided.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to refactor how filings and fixings data are passed to a GitHub Actions script by switching from environment variables to direct interpolation. However, the implementation contains a critical bug that will break the action.
Key Issue
- The outputs
filingsandfixingsare stringified JSON that must be parsed, but the new code removesJSON.parse()and attempts direct interpolation, which will cause syntax errors
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abdulahmad307
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.