[GHSA-p5wg-g6qr-c7cg] eslint has a Stack Overflow when serializing objects with circular references #6758
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR modifies a GitHub Security Advisory (GHSA) to reclassify an ESLint stack overflow issue as not being a security vulnerability. The change reflects the position that stack overflow issues in developer tools like ESLint, which run on trusted input, should not be treated as security vulnerabilities.
Changes:
- Updated the advisory summary from describing a specific vulnerability to "Not a vulnerability"
- Removed the CWE-674 classification (Uncontrolled Recursion)
- Updated the modification timestamp
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Comments
A possible stack overflow in eslint shouldn't be a security vulnerability. Eslint is running on trusted or semi trusted input, if it fails in this manor its not going to cause service outages, data leakages or remote access. By allowing 'security issues' like this into the database you are undermining trust in the database as a whole.
This should be getting reoported on eslint issues on their repo, not in the vulnerability db