Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the dialog-toggle-events polyfill to resolve browser error reporting issues in an older version of Firefox.
- Removed import of dialog-toggle-events
- Adjusted the polyfills object and simplified the isSupported() function to return only baseSupport
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/index.ts:59
- [nitpick] The isSupported() function now only checks baseSupport after removing the dialog-toggle-events polyfill. Please confirm that this simplification is intended and that support checks for the remaining polyfills can be safely omitted.
return baseSupport
b02f2f7 to
bf119cd
Compare
dgreif
approved these changes
Apr 14, 2025
Contributor
dgreif
left a comment
There was a problem hiding this comment.
Thanks for removing this for now. We probably need to cut a major release since this is technically a breaking change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to remove the
dialog-toggle-events-polyfillfrom the package. This code change is necessary because the polyfill is disrupting the browser error reporting in old versions of Firefox.I will test this code change in
review-labbefore attempting the upgrade in Dotcom.I verified the
dialog-toggle-events polyfillis not used in any other place in thebrowser-supportpackage and Doctom: