Merge releases/v4 into releases/v3#3481
Conversation
Disable TypeScript `noUnusedLocals` and `noUnusedParameters` options, already covered by eslint
Mergeback v4.32.2 refs/heads/releases/v4 into main
Bumps the npm-minor group with 2 updates: [@eslint/compat](https://github.com/eslint/rewrite/tree/HEAD/packages/compat) and [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc). Updates `@eslint/compat` from 2.0.1 to 2.0.2 - [Release notes](https://github.com/eslint/rewrite/releases) - [Changelog](https://github.com/eslint/rewrite/blob/main/packages/compat/CHANGELOG.md) - [Commits](https://github.com/eslint/rewrite/commits/compat-v2.0.2/packages/compat) Updates `eslint-plugin-jsdoc` from 62.4.1 to 62.5.0 - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Commits](gajus/eslint-plugin-jsdoc@v62.4.1...v62.5.0) --- updated-dependencies: - dependency-name: "@eslint/compat" dependency-version: 2.0.2 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm-minor - dependency-name: eslint-plugin-jsdoc dependency-version: 62.5.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the actions-minor group with 1 update in the /.github/workflows directory: [ruby/setup-ruby](https://github.com/ruby/setup-ruby). Updates `ruby/setup-ruby` from 1.286.0 to 1.288.0 - [Release notes](https://github.com/ruby/setup-ruby/releases) - [Changelog](https://github.com/ruby/setup-ruby/blob/master/release.rb) - [Commits](ruby/setup-ruby@90be115...09a7688) --- updated-dependencies: - dependency-name: ruby/setup-ruby dependency-version: 1.288.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Pushed a commit to rebuild the Action. Please mark the PR as ready for review to trigger PR checks. |
There was a problem hiding this comment.
Pull request overview
This PR merges changes from releases/v4 into releases/v3, bumping the v3 release to 3.32.3 and bringing in updates around feature flags, API retry behavior, and start-proxy private registry connectivity checks.
Changes:
- Bump release version to 3.32.3 and add a changelog entry.
- Add optional (FF-gated) private registry reachability checks to the
start-proxyaction. - Adjust feature-flag behavior for CCR/GHES and update API retry behavior; refresh dependencies and CI Ruby action pin.
Reviewed changes
Copilot reviewed 25 out of 28 changed files in this pull request and generated 29 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Disables TS unused locals/params checks (relying on eslint). |
| src/start-proxy/types.ts | Introduces shared types for registry credentials and address handling. |
| src/start-proxy/reachability.ts | Adds reachability checker implementation using https-proxy-agent. |
| src/start-proxy/reachability.test.ts | Adds unit tests for reachability checking and logging. |
| src/start-proxy.ts | Refactors credential parsing/validation to use new types and validates required fields. |
| src/start-proxy.test.ts | Adds coverage for missing type and updates credential string tests. |
| src/start-proxy-action.ts | Initializes feature flags and adds FF-gated registry reachability checks. |
| src/feature-flags.ts | Adds new feature flag and skips remote FF API calls in CCR; updates logging. |
| src/feature-flags.test.ts | Adds CCR defaulting test and refactors repeated assertions. |
| src/api-client.ts | Tweaks Octokit retry configuration to retry auth-like failures. |
| src/api-client.test.ts | Updates expected Octokit client options for retry configuration. |
| pr-checks/checks/rubocop-multi-language.yml | Updates ruby/setup-ruby pin to v1.288.0. |
| package.json | Bumps version to 3.32.3 and adds https-proxy-agent; updates dev deps. |
| package-lock.json | Updates lockfile for dependency changes (but version metadata needs alignment). |
| CHANGELOG.md | Adds 3.32.3 release entry describing the start-proxy connectivity checks. |
| .github/workflows/__rubocop-multi-language.yml | Generated workflow update for ruby/setup-ruby pin. |
| lib/upload-sarif-action.js | Generated build output update (not reviewed). |
| lib/upload-sarif-action-post.js | Generated build output update (not reviewed). |
| lib/upload-lib.js | Generated build output update (not reviewed). |
| lib/start-proxy-action-post.js | Generated build output update (not reviewed). |
| lib/setup-codeql-action.js | Generated build output update (not reviewed). |
| lib/resolve-environment-action.js | Generated build output update (not reviewed). |
| lib/init-action.js | Generated build output update (not reviewed). |
| lib/init-action-post.js | Generated build output update (not reviewed). |
| lib/autobuild-action.js | Generated build output update (not reviewed). |
| lib/analyze-action.js | Generated build output update (not reviewed). |
| lib/analyze-action-post.js | Generated build output update (not reviewed). |
| .filter((credential) => credential.url !== undefined) | ||
| .map((credential) => ({ | ||
| type: credential.type, | ||
| url: credential.url, | ||
| })); |
There was a problem hiding this comment.
startProxy builds registry_urls (and the returned ProxyInfo.registries) by filtering to credentials with a defined url. Credentials configured with only host will be excluded from the new reachability checks, so they will never be tested even when the feature flag is enabled. Consider including host-only registries in ProxyInfo (and/or proxy_urls) so checkConnections can attempt them (it already logs and skips invalid/non-URL addresses).
| .filter((credential) => credential.url !== undefined) | |
| .map((credential) => ({ | |
| type: credential.type, | |
| url: credential.url, | |
| })); | |
| .filter((credential) => credential.url !== undefined || credential.host !== undefined) | |
| .map((credential) => { | |
| // Prefer an explicit URL if provided; otherwise, derive one from the host. | |
| const url = credential.url ?? (credential.host ? `https://${credential.host}` : undefined); | |
| return { | |
| type: credential.type, | |
| url, | |
| }; | |
| }); |
There was a problem hiding this comment.
The value assigned to MatchKind here is unused.
There was a problem hiding this comment.
The value assigned to CacheFilename here is unused.
There was a problem hiding this comment.
The value assigned to CompressionMethod here is unused.
There was a problem hiding this comment.
The value assigned to ArchiveToolType here is unused.
There was a problem hiding this comment.
This use of variable 'CacheFilename' always evaluates to false.
There was a problem hiding this comment.
This use of variable 'CompressionMethod' always evaluates to false.
There was a problem hiding this comment.
This use of variable 'ArchiveToolType' always evaluates to false.
There was a problem hiding this comment.
This use of variable 'KnownLanguage' always evaluates to false.
There was a problem hiding this comment.
This use of variable 'AnalysisKind' always evaluates to false.
Merging 9e907b5 into
releases/v3.Conductor for this PR is @henrymercer.
Contains the following pull requests:
noUnusedLocalsandnoUnusedParametersoptions, already covered by eslint #3464 (@mbg)start-proxy#3466 (@mbg)Please do the following:
releases/v3branch.Create a merge commitis selected rather thanSquash and mergeorRebase and merge.