-
Notifications
You must be signed in to change notification settings - Fork 1.9k
C#: Support .slnx. solution files.
#21016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michaelnebel
wants to merge
8
commits into
github:main
Choose a base branch
from
michaelnebel:csharp/slnx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+202
−60
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
247d764
C#: Add autobuilder integration tests with .slnx file.
michaelnebel 166ce1b
C#: Add buildless integration test example including .slnx file.
michaelnebel 5212e63
C#: Add dependency Microsoft.VisualStudio.SolutionPersistence and upd…
michaelnebel d31a297
C#: Make support for .slnx files.
michaelnebel 23981b4
C#: Update integration test expected output.
michaelnebel efb5853
C#: Add change-note.
michaelnebel b8def10
C#: Claim support for .slnx in the public documentation.
michaelnebel ea7e158
C#: Update integration test expected output.
michaelnebel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 8 additions & 0 deletions
8
csharp/ql/integration-tests/all-platforms/autobuild_slnx/Files.expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| | proj1/Program.cs:0:0:0:0 | proj1/Program.cs | | ||
| | proj1/obj/Debug/net10.0/.NETCoreApp,Version=v10.0.AssemblyAttributes.cs:0:0:0:0 | proj1/obj/Debug/net10.0/.NETCoreApp,Version=v10.0.AssemblyAttributes.cs | | ||
| | proj1/obj/Debug/net10.0/proj1.AssemblyInfo.cs:0:0:0:0 | proj1/obj/Debug/net10.0/proj1.AssemblyInfo.cs | | ||
| | proj1/obj/Debug/net10.0/proj1.GlobalUsings.g.cs:0:0:0:0 | proj1/obj/Debug/net10.0/proj1.GlobalUsings.g.cs | | ||
| | proj2/Program.cs:0:0:0:0 | proj2/Program.cs | | ||
| | proj2/obj/Debug/net10.0/.NETCoreApp,Version=v10.0.AssemblyAttributes.cs:0:0:0:0 | proj2/obj/Debug/net10.0/.NETCoreApp,Version=v10.0.AssemblyAttributes.cs | | ||
| | proj2/obj/Debug/net10.0/proj2.AssemblyInfo.cs:0:0:0:0 | proj2/obj/Debug/net10.0/proj2.AssemblyInfo.cs | | ||
| | proj2/obj/Debug/net10.0/proj2.GlobalUsings.g.cs:0:0:0:0 | proj2/obj/Debug/net10.0/proj2.GlobalUsings.g.cs | |
5 changes: 5 additions & 0 deletions
5
csharp/ql/integration-tests/all-platforms/autobuild_slnx/Files.ql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import csharp | ||
|
|
||
| from File f | ||
| where f.fromSource() | ||
| select f |
3 changes: 3 additions & 0 deletions
3
csharp/ql/integration-tests/all-platforms/autobuild_slnx/autobuild_slnx.slnx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <Solution> | ||
| <Project Path="proj1/proj1.csproj" /> | ||
| </Solution> | ||
5 changes: 5 additions & 0 deletions
5
csharp/ql/integration-tests/all-platforms/autobuild_slnx/global.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "sdk": { | ||
| "version": "10.0.100" | ||
| } | ||
| } |
2 changes: 2 additions & 0 deletions
2
csharp/ql/integration-tests/all-platforms/autobuild_slnx/proj1/Program.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| // See https://aka.ms/new-console-template for more information | ||
| Console.WriteLine("Hello, World!"); |
10 changes: 10 additions & 0 deletions
10
csharp/ql/integration-tests/all-platforms/autobuild_slnx/proj1/proj1.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net10.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| </PropertyGroup> | ||
|
|
||
| </Project> |
2 changes: 2 additions & 0 deletions
2
csharp/ql/integration-tests/all-platforms/autobuild_slnx/proj2/Program.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| // See https://aka.ms/new-console-template for more information | ||
| Console.WriteLine("Hello, World!"); |
10 changes: 10 additions & 0 deletions
10
csharp/ql/integration-tests/all-platforms/autobuild_slnx/proj2/proj2.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net10.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| </PropertyGroup> | ||
|
|
||
| </Project> |
3 changes: 3 additions & 0 deletions
3
csharp/ql/integration-tests/all-platforms/autobuild_slnx/test.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| def test(codeql, csharp): | ||
| # Only proj1 is included in the solution, so only it should be built (and extracted). | ||
| codeql.database.create() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know there is a comment in
test.pyalready, but perhaps add one here as well saying that the exclusion ofproj2is deliberate.