Brodes/nested sizeof or operation in sizeof audit fixes #21052
Closed
+280,000
−1,476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PS: Add `Node.getCallee` predicate on `DataFlow::CallNode`
…ith a small pipeline.
PS: Fix FPs on `powershell/microsoft/public/sql-injection`
PS: Fix lots of performance problems
…hey were there, but too confusing to have repeating tests.
…cro.ql Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com>
Fix FPs in sizeof queries
Update next dependency version to 15.1.9
C++: Support macro flow when the macro generates a child expression o…
…taFlowPrivate.qll
Sync upstream `v2.23.8`
Contributor
Author
|
Sigh... accidentally PR'ed up stream. Why is the default not my fork... |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses false positive fixes resulting from a new audit for nested sizeof or operation in sizeof operations. The changes consist entirely of adding auto-generated stub files for the Microsoft Identity Service Essentials SDK version 1.19.7-preview-41027191730, along with a new test case for Azure AD token validation.
Key Changes
- Addition of comprehensive auto-generated stub files for Microsoft.Identity.ServiceEssentials.SDK
- New test case for Wilson library Azure Active Directory token validation
Reviewed changes
Copilot reviewed 256 out of 4382 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Microsoft.IdentityModel.S2S.cs | Auto-generated stub for S2S authentication models and handlers |
| Microsoft.IdentityModel.S2S.Tokens.cs | Auto-generated stub for S2S token management and validation |
| Microsoft.IdentityModel.Protocols.cs | Auto-generated stub for protocol configuration and retrieval |
| Microsoft.IdentityModel.Protocols.SignedHttpRequest.cs | Auto-generated stub for signed HTTP request validation |
| Microsoft.IdentityModel.Protocols.OpenIdConnect.cs | Auto-generated stub for OpenID Connect protocol support |
| Microsoft.IdentityModel.Logging.cs | Auto-generated stub for identity model logging infrastructure |
| Microsoft.IdentityModel.JsonWebTokens.cs | Auto-generated stub for JSON Web Token handling |
| Microsoft.IdentityModel.Abstractions.cs | Auto-generated stub for identity model abstractions |
| Microsoft.Identity.ServiceEssentials.TokenAcquisition.cs | Auto-generated stub for token acquisition functionality |
| Microsoft.Identity.ServiceEssentials.Modules.TrV2Module.cs | Auto-generated stub for Tenant Restrictions V2 module |
| Microsoft.Identity.ServiceEssentials.Core.cs | Auto-generated stub for core MISE functionality |
| Microsoft.Identity.ServiceEssentials.Caching.cs | Auto-generated stub for MISE caching infrastructure |
| Microsoft.Identity.ServiceEssentials.Authentication.cs | Auto-generated stub for MISE authentication components |
| Microsoft.Identity.Abstractions.cs | Auto-generated stub for Microsoft Identity abstractions |
| Microsoft.Extensions.Primitives.cs | Auto-generated stub for extension primitives |
| Microsoft.Extensions.Options.cs | Auto-generated stub for options pattern support |
| Microsoft.Extensions.Options.ConfigurationExtensions.cs | Auto-generated stub for options configuration binding |
| Microsoft.Extensions.Logging.cs | Auto-generated stub for logging infrastructure |
| Microsoft.Extensions.Logging.Abstractions.cs | Auto-generated stub for logging abstractions |
| Microsoft.Extensions.DependencyInjection.cs | Auto-generated stub for dependency injection |
| Microsoft.Extensions.Configuration.Binder.cs | Auto-generated stub for configuration binding |
| AadValidation.cs | Test case for Azure AD token validation scenarios |
| AadIssuerValidationDataFlow.qlref | Query reference for AAD issuer validation data flow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public const string JWK = default; | ||
| public const string JWT = default; | ||
| public const string TlsTbh = default; | ||
| public static System.Collections.Generic.IList<string> VaildAzpValues; |
There was a problem hiding this comment.
Corrected spelling of 'VaildAzpValues' to 'ValidAzpValues'.
Suggested change
| public static System.Collections.Generic.IList<string> VaildAzpValues; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
False positive fixes as a result of a new Audit.