Co-locate WithSchemaCache with other With functions#1995
Merged
SamMorrowDrums merged 2 commits intosammorrowdrums/add-schema-cache-httpfrom Feb 11, 2026
Merged
Conversation
Co-authored-by: SamMorrowDrums <4811358+SamMorrowDrums@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor WithSchemaCache location in file
Co-locate WithSchemaCache with other With functions
Feb 11, 2026
487cf0b
into
sammorrowdrums/add-schema-cache-http
4 checks passed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is a small refactor in the HTTP handler to improve code organization by grouping the WithSchemaCache HandlerOption with the other With* option builders in pkg/http/handler.go.
Changes:
- Moved
WithSchemaCachefrom near the imports to the existing block ofHandlerOptionfunctions (no logic changes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moved
WithSchemaCacheto be grouped with otherHandlerOptionfunctions inpkg/http/handler.go.Why
Code organization feedback from PR #1993. Option builder functions should be co-located.
What changed
WithSchemaCachefrom top of file (after imports) to line 78, grouped withWithScopeFetcher,WithGitHubMCPServerFactory,WithInventoryFactory,WithOAuthConfig, andWithFeatureCheckerMCP impact
Pure refactor, no behavioral changes.
Prompts tested (tool changes only)
N/A
Security / limits
Tool renaming
Lint & tests
./script/lint./script/testDocs
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.