Skip to content

Implement pagination for uiGetBranches #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattdholloway merged 2 commits into from
Feb 13, 2026
Merged

Implement pagination for uiGetBranches #2012

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e00450
Initial plan
Copilot Feb 13, 2026
41a6834
Implement pagination for uiGetBranches function
Copilot Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions pkg/github/ui_tools.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,29 +270,28 @@ func uiGetBranches(ctx context.Context, deps ToolDependencies, args map[string]a

client, err := deps.GetClient(ctx)
if err != nil {
return nil, nil, fmt.Errorf("failed to get GitHub client: %w", err)
return utils.NewToolResultErrorFromErr("failed to get GitHub client", err), nil, nil
}

opts := &github.BranchListOptions{
ListOptions: github.ListOptions{PerPage: 100},
}

branches, resp, err := client.Repositories.ListBranches(ctx, owner, repo, opts)
if err != nil {
return ghErrors.NewGitHubAPIErrorResponse(ctx, "failed to list branches", resp, err), nil, nil
}
defer func() { _ = resp.Body.Close() }()

if resp.StatusCode != http.StatusOK {
body, err := io.ReadAll(resp.Body)
var allBranches []*github.Branch
for {
branches, resp, err := client.Repositories.ListBranches(ctx, owner, repo, opts)
if err != nil {
return nil, nil, fmt.Errorf("failed to read response body: %w", err)
return ghErrors.NewGitHubAPIErrorResponse(ctx, "failed to list branches", resp, err), nil, nil
}
allBranches = append(allBranches, branches...)
if resp.NextPage == 0 {
break
}
return ghErrors.NewGitHubAPIStatusErrorResponse(ctx, "failed to list branches", resp, body), nil, nil
opts.Page = resp.NextPage
}

minimalBranches := make([]MinimalBranch, 0, len(branches))
for _, branch := range branches {
minimalBranches := make([]MinimalBranch, 0, len(allBranches))
for _, branch := range allBranches {
minimalBranches = append(minimalBranches, convertToMinimalBranch(branch))
}

Expand All @@ -301,7 +300,7 @@ func uiGetBranches(ctx context.Context, deps ToolDependencies, args map[string]a
"totalCount": len(minimalBranches),
})
if err != nil {
return nil, nil, fmt.Errorf("failed to marshal response: %w", err)
return utils.NewToolResultErrorFromErr("failed to marshal response", err), nil, nil
}

return utils.NewToolResultText(string(r)), nil, nil
Expand Down
Loading