Simplify usage of the bump CLI workflow#3915
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
extensions/ql-vscode/scripts/bump-supported-cli-versions.ts:30
- This line may throw an error if existingVersions is empty or not valid. Consider handling the case where existingVersions[0] is undefined or invalid before creating a SemVer object.
const latestSupportedVersion = new SemVer(existingVersions[0]);
extensions/ql-vscode/scripts/bump-supported-cli-versions.ts:12
- [nitpick] This newly introduced function does not appear to have associated tests. Please add coverage to ensure that the version replacement and prepending logic works as intended.
async function bumpSupportedCliVersions() {
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
aeisenberg
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the
bump-cliworkflow by removing the need to specifyreplaceorprependand removes the need to specify a version. Instead, we use a TypeScript script that automatically determines these options:supported_cli_versions.json