Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates Jest dependencies from an alpha version (30.0.0-alpha.7) to a stable release (30.2.0), which is needed to unblock another pull request. The update moves away from pre-release versions to a production-ready version of Jest.
- Upgraded
@jest/environmentfrom v30.0.0-alpha.7 to v30.2.0 - Upgraded
@jest/environment-jsdom-abstractfrom v30.0.0-alpha.7 to v30.2.0
Files not reviewed (1)
- extensions/ql-vscode/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
robertbrignull
approved these changes
Oct 27, 2025
Contributor
robertbrignull
left a comment
robertbrignull
left a comment
There was a problem hiding this comment.
LGTM. Makes sense to me to do this upgrade and get back onto normal releases if we can.
koesie10
approved these changes
Oct 27, 2025
Member
koesie10
left a comment
koesie10
left a comment
There was a problem hiding this comment.
LGTM, although I think it would also make sense to update the version of the jest package itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the jest version, which should unblock #4174. (I'm not sure why dependabot hasn't suggested this update yet—possibly because we were on a weird alpha version of jest previously.)
Anyway, see #4174 (comment) for the details!
(ℹ️ Note: I don't plan to merge this until after the GH Universe code freeze is lifted 🧊)