-
Notifications
You must be signed in to change notification settings - Fork 38
Add agent-runner environment parity test suite #12130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
🔍 PR Triage ResultsCategory: test | Risk: low | Priority: 47/100 Scores Breakdown
📋 Recommended Action: batch_reviewExcellent addition of comprehensive integration tests for agent-runner environment parity. This PR validates that the agent container has access to essential utilities, runtimes, environment variables, and shared libraries. Test Coverage:
Related PRs: This test suite complements #12062 and #12085 which mount binaries and libraries. Triaged by PR Triage Agent on 2026-01-28T00:34:49Z
|
🔍 PR Triage ResultsCategory: test | Risk: low | Priority: 37/100 Scores Breakdown
📋 Recommended Action: deferRationale: This PR adds comprehensive integration tests and smoke test workflows for agent-runner environment parity (utilities, runtimes, environment variables, shared libraries). While important for preventing regressions, it should remain deferred until out of draft. The changes are substantial (2,340 additions across 7 files) and need CI validation before review. Next steps: Mark as ready for review when all integration tests pass and CI is green. Triaged by PR Triage Agent on 2026-01-28
|
🔍 PR Triage ResultsCategory: feature | Risk: high | Priority: 47/100 Scores Breakdown
📋 Recommended Action: batch_reviewThis PR is part of batch-feature-high (6 PRs) - high-risk feature additions requiring careful review. Test suite additions are valuable but need thorough review for coverage and correctness. Batch PRs: #12322, #12321, #12320, #12311, #12130, #12085 Triaged by PR Triage Agent on 2026-01-28T18:16:26Z
|
|
/q update pr triage agent to only add labels from a limited set of values. It is adding too Many labels. See this issue. |
|
🎩 Mission equipment ready! Q has optimized your workflow. Use wisely, 007! 🔫 |
🔍 Q Investigation CompleteI've investigated the label proliferation issue you mentioned and created a fix. Problem FoundThis PR (#12130) demonstrates the issue perfectly:
Root CauseThe PR triage agent workflow ( safe-outputs:
add-labels:
max: 100
# Omitting 'allowed' to permit dynamic label creationThis allowed unlimited labels including:
SolutionI've created a PR that:
Next StepsOnce the PR is merged, the triage agent will only add 4 well-defined labels per PR, preventing the conflicts seen here. Q - Workflow Optimizer
|
Automated validation that the agent container environment maintains parity with GitHub Actions runners for utilities, runtimes, environment variables, and shared libraries. Prevents regressions as we close the gap between agent and runner environments.
Integration Tests (
pkg/workflow/agent_parity_test.go)Five test functions validate workflow compilation for environment parity checks:
lddvalidation for python3, node, git, curl binariesTests generate workflow markdown, compile to lock files, and assert expected content is present.
Smoke Test Workflow (
.github/workflows/agent-runner-parity.md)Production validation workflow that:
Example output format:
Documentation (
specs/agent-container-testing.md)Coverage tables for all test categories, test execution flows, extension instructions, troubleshooting guide.
Build Integration
make test-parityruns integration tests with proper build tags and filters.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.