feat: format display attributes on GitifyNotification #2502
+442
−276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Setch <adam.setch@outlook.com>
github-actions
bot
added
the
enhancement
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
afonsojramos
approved these changes
Jan 11, 2026
Co-authored-by: Afonso Jorge Ramos <afonsojorgeramos@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
displaysection to ourGitifyNotificationtype and a final formatting stage.Notification stages are now:
fetch→transform→base filter→enrich→detail filter→format→ordering/stabilizingMoved across several of our formatting calls to be part of the
formatNotificationfunction [note: there are more, these will follow in follow up PRs].As part of this refactor, I have also simplified the handler interface to focus on parts that vary between notification types (previously it was also performing some base formatting duties)