fix: remote git taskfile cloning and directory includes #2602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xplicit ref When no ref is specified in a remote Taskfile URL, go-getter was being passed ref=HEAD which git interprets as a literal branch name, causing "Remote branch HEAD not found" errors. Now we omit the ref parameter entirely when not specified, letting git clone the remote's default branch.
When a remote Taskfile includes another Taskfile using a directory path (e.g., `taskfile: ./website`), use fsext.SearchPath to properly resolve it by searching for Taskfile.yml inside the directory. This also simplifies the logic by delegating all path resolution to SearchPath, which handles both file and directory paths.
vmaerten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Two issues with remote git Taskfiles:
When no
refis specified in the URL,go-getterwas passedref=HEADwhich git interprets as a literal branch name, causing clone failures.When a remote Taskfile includes another using a directory path (e.g.,
taskfile: ./website), the code tried to read the directory as a file instead of searching forTaskfile.ymlinside it.Solution
Omit the
refparameter entirely when not specified, letting git clone the remote's default branch.Use
fsext.SearchPathto resolve paths, which handles both files and directories transparently.