Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contrib/spring-ai/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ To use ADK Java with the Spring AI integration in your application, add the foll
<dependency>
<groupId>org.springframework.ai</groupId>
<artifactId>spring-ai-bom</artifactId>
<version>1.1.0-M3</version>
<version>1.1.1</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Comment on lines 32 to 38
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The usage of a Bill of Materials (BOM) with scope=import is only supported within a <dependencyManagement> section in Maven. This example incorrectly places the spring-ai-bom dependency directly inside the <dependencies> block.

To ensure the example is correct and works as expected for users, this dependency should be moved into a <dependencyManagement> section. The "Complete Example pom.xml" later in this document demonstrates the correct usage.

For example:

<dependencyManagement>
    <dependencies>
        <dependency>
            <groupId>org.springframework.ai</groupId>
            <artifactId>spring-ai-bom</artifactId>
            <version>1.1.1</version>
            <type>pom</type>
            <scope>import</scope>
        </dependency>
    </dependencies>
</dependencyManagement>

Expand Down Expand Up @@ -115,7 +115,7 @@ Add the Spring AI provider dependencies for the AI services you want to use:

<properties>
<java.version>17</java.version>
<spring-ai.version>1.1.0-M3</spring-ai.version>
<spring-ai.version>1.1.1</spring-ai.version>
<adk.version>0.3.1-SNAPSHOT</adk.version>
</properties>

Expand Down
2 changes: 1 addition & 1 deletion contrib/spring-ai/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<description>Spring AI integration for the Agent Development Kit.</description>

<properties>
<spring-ai.version>1.1.0</spring-ai.version>
<spring-ai.version>1.1.1</spring-ai.version>
<testcontainers.version>1.21.3</testcontainers.version>
</properties>

Expand Down