-
Notifications
You must be signed in to change notification settings - Fork 256
fix: add media/image support in Spring AI MessageConverter #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: add media/image support in Spring AI MessageConverter #706
Conversation
Summary of ChangesHello @prasadskarmarkar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces crucial enhancements to the Spring AI MessageConverter by enabling full support for image and media attachments. Previously, the converter was limited to text-only content, which prevented the successful execution of vision model requests. The updated logic now ensures that UserMessage objects are correctly built with media parts, resolving issue #705 and allowing for richer, multimodal interactions with AI models. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively adds support for media and image attachments to the MessageConverter, which was a missing feature. The implementation is straightforward and correct. The addition of comprehensive unit tests covering various scenarios (inline data, file URI, multiple attachments, media-only messages) is excellent and ensures the new functionality is well-tested. I have a few minor suggestions to improve code conciseness and test robustness.
contrib/spring-ai/src/main/java/com/google/adk/models/springai/MessageConverter.java
Outdated
Show resolved
Hide resolved
contrib/spring-ai/src/test/java/com/google/adk/models/springai/MessageConverterTest.java
Outdated
Show resolved
Hide resolved
contrib/spring-ai/src/test/java/com/google/adk/models/springai/MessageConverterTest.java
Outdated
Show resolved
Hide resolved
Previously, MessageConverter only transferred text content from ADK to Spring AI, ignoring image and media attachments. This caused vision model requests to fail even though Spring AI's underlying models (like GPT-4o) support image inputs. Updated MessageConverter to properly handle image/media parts by constructing UserMessage with Media attachments. Fixes google#705
61dc626 to
a6ad0c8
Compare
Previously, MessageConverter only transferred text content from ADK to Spring AI, ignoring image and media attachments. This caused vision model requests to fail even though Spring AI's underlying models (like GPT-4o) support image inputs.
Updated MessageConverter to properly handle image/media parts by constructing UserMessage with Media attachments.
Fixes #705