Skip to content

Conversation

@prasadskarmarkar
Copy link

Previously, MessageConverter only transferred text content from ADK to Spring AI, ignoring image and media attachments. This caused vision model requests to fail even though Spring AI's underlying models (like GPT-4o) support image inputs.

Updated MessageConverter to properly handle image/media parts by constructing UserMessage with Media attachments.

Fixes #705

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @prasadskarmarkar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces crucial enhancements to the Spring AI MessageConverter by enabling full support for image and media attachments. Previously, the converter was limited to text-only content, which prevented the successful execution of vision model requests. The updated logic now ensures that UserMessage objects are correctly built with media parts, resolving issue #705 and allowing for richer, multimodal interactions with AI models.

Highlights

  • Enhanced Media Support: The MessageConverter now correctly processes image and media attachments from the ADK, enabling vision model requests that previously failed due to ignored media content.
  • Conditional UserMessage Construction: The handleUserContent method has been updated to conditionally construct UserMessage objects, including media attachments when present, using UserMessage.builder().media(mediaList).build().
  • Comprehensive Test Coverage: New unit tests have been added to MessageConverterTest to validate the proper handling of inline media, file-based media, multiple media attachments, and messages containing only media.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively adds support for media and image attachments to the MessageConverter, which was a missing feature. The implementation is straightforward and correct. The addition of comprehensive unit tests covering various scenarios (inline data, file URI, multiple attachments, media-only messages) is excellent and ensures the new functionality is well-tested. I have a few minor suggestions to improve code conciseness and test robustness.

Previously, MessageConverter only transferred text content from ADK to Spring AI,
ignoring image and media attachments. This caused vision model requests to fail
even though Spring AI's underlying models (like GPT-4o) support image inputs.

Updated MessageConverter to properly handle image/media parts by constructing
UserMessage with Media attachments.

Fixes google#705
@prasadskarmarkar prasadskarmarkar force-pushed the fix/spring-ai-media-support branch from 61dc626 to a6ad0c8 Compare January 7, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google ADK is also lazy, Spring AI only has text transfer - 期待Google ADK修复

1 participant