feat: use toolbox-adk and align validation to allow default loading

[anubhav756]

Link to Issue or Description of Change

1. Link to an existing issue (if applicable):

• Related: refactor(tools): Update ToolboxToolset to wrap toolbox-adk #3888

Note

This PR includes changes that depend on functionality introduced in #3888. Please review and merge #3888 first.

2. Or, if no issue exists, describe the change:

Problem:
The sample agent code was using the legacy toolbox-core package, which is being superseded by toolbox-adk. Additionally, ToolboxToolset had a validation check enforcing either toolset_name or tool_names to be present, preventing the default behavior of loading all tools when parameters are omitted (which toolbox-adk supports).

Solution:

• Updated the sample agent code to import and use toolbox-adk.
• Removed the restrictive validation check in ToolboxToolset to allow default loading of all tools, aligning with toolbox-adk behavior.

Testing Plan

Unit Tests:

• I have added or updated unit tests for my change.
• All unit tests pass locally.

Manual End-to-End (E2E) Tests:

• Verified that the sample agent runs correctly with toolbox-adk locally.
• Verified that ToolboxToolset can now be instantiated without arguments to load all tools.

Checklist

• I have read the CONTRIBUTING.md document.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.
• I have manually tested my changes end-to-end.
• Any dependent changes have been merged and published in downstream modules.

[gemini-code-assist]

Summary of Changes

Hello @anubhav756, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the ToolboxToolset class to integrate with the toolbox-adk package, replacing the older toolbox-core dependency. The primary goal is to streamline the process of loading tools by removing a restrictive validation, allowing the toolset to load all tools by default when specific names are not provided. This update also introduces new configuration options for enhanced flexibility and ensures the class's behavior is consistent with the capabilities of the toolbox-adk package.

Highlights

• Dependency Update: The project now utilizes toolbox-adk instead of toolbox-core, updating the core dependency for toolbox interactions.
• Validation Removal: The ToolboxToolset no longer requires toolset_name or tool_names to be explicitly provided during initialization, removing a previous ValueError check.
• Default Tool Loading: This change enables the ToolboxToolset to load all available tools by default if no specific toolset_name or tool_names are supplied, aligning with the toolbox-adk package's behavior.
• Refactored ToolboxToolset: The ToolboxToolset class has been refactored to act as a wrapper around toolbox_adk.ToolboxToolset, delegating its core logic and simplifying its implementation.
• New Configuration Options: The ToolboxToolset constructor now accepts credentials and additional_headers parameters, providing more flexibility for authentication and request customization.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[adk-bot]

Response from ADK Triaging Agent

Hello @anubhav756, thank you for creating this PR!

To help us review this PR, could you please associate the GitHub issue with this PR? If there is no existing issue, could you please create one?

In addition, could you please provide a testing plan section in your PR to describe how you tested your changes?

This information will help reviewers to review your PR more efficiently. Thanks!

[gemini-code-assist]

Code Review

This pull request updates the ToolboxToolset to use the toolbox-adk package, replacing toolbox-core. This simplifies the implementation by delegating tool loading to toolbox-adk. The change also removes the validation that required either toolset_name or tool_names, allowing all tools to be loaded by default. My review focuses on the correctness of this refactoring. I've found a critical issue with type compatibility in the get_tools method and a minor issue with docstring formatting. Please see my detailed comments.

[averikitsch]

nit: NativeToolboxToolset?

[ryanaiagent]

Hi @anubhav756 , Thank you for your contribution! We appreciate you taking the time to submit this pull request.
Hi @wyf7107 , can you please review this