Promote google.adk.cli.fast_api.get_fast_api_app to public namespace#4560
Open
olliefr wants to merge 3 commits intogoogle:mainfrom
Open
Promote google.adk.cli.fast_api.get_fast_api_app to public namespace#4560olliefr wants to merge 3 commits intogoogle:mainfrom
google.adk.cli.fast_api.get_fast_api_app to public namespace#4560olliefr wants to merge 3 commits intogoogle:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Link to an existing issue:
Problem:
As described in the aforementioned issue, a method from one of the ADK modules is being used in multiple places in the official ADK documentation yet there is no API Reference docs generated for it at the moment.
Solution:
I'm simply following the plan devised by @klateefa as detailed in the aforementioned issue.
This is my first PR to the ADK repo so help is welcome.
My understanding is that once this PR is merged, the API Reference docs can be regenerated and then they will pick up and include the docstrings for the method in question.
I'm also going to submit a related PR to the
adk-docsrepo to include the module from this PR in the documentation build.Testing Plan
I run
./scripts/unittests.shas directed by the instructions inCONTRIBUTING.md.Unit Tests:
A summary of passed
pytestresults:Manual End-to-End (E2E) Tests:
Once this PR is merged, followed by the PR in
adk-docs, Python API Reference should include the docs forgoogle.adk.cli.fast_api.get_fast_api_appmethod:https://google.github.io/adk-docs/api-reference/python/google-adk.html#module-google.adk.cli
Checklist
Additional context
I will update this PR once I had submitted the one for
adk-docs.