-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore: Update workflow and tools to use Go 1.26 and 1.25 #3995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3995 +/- ##
=======================================
Coverage 93.52% 93.52%
=======================================
Files 207 207
Lines 17591 17597 +6
=======================================
+ Hits 16452 16458 +6
Misses 938 938
Partials 201 201 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Not-Dhananjay-Mishra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just one question should we update README.md as well?
Lines 15 to 16 in 1732098
| We do our best not to break older versions of Go if we don't have to, but we | |
| don't explicitly test older versions and as of Go 1.23 the go directive in |
No, that section should stay the same. |
alexandear
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we ship this change after the go-github release with all the breaking changes? I mean releasing v83 first and then updating the go.mod to Go 1.25.
Co-authored-by: Oleksandr Redko <oleksandr.red+github@gmail.com>
Great idea, @alexandear - placing this PR on hold until after the release of |
cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra