feat(NVD): have NVD conversion indiscriminately output records regardless of git resolution outcome#4747
Open
jess-lowe wants to merge 13 commits intogoogle:masterfrom
Open
feat(NVD): have NVD conversion indiscriminately output records regardless of git resolution outcome#4747jess-lowe wants to merge 13 commits intogoogle:masterfrom
jess-lowe wants to merge 13 commits intogoogle:masterfrom
Conversation
another-rex
reviewed
Feb 12, 2026
| } | ||
|
|
||
| if rejectFailed && metrics.Outcome != models.Successful { | ||
| return metrics.Outcome |
Contributor
There was a problem hiding this comment.
Is it intentional that we don't write the metrics file if outcome fails? e.g. there are no affected commits
Can you add a comment here stating that if it is intentional and why.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
database_specificfield - future work will involve placing these ataffected.ranges.database_specificlevel, but more reworking will need to be done to complete that.