build: clear 'requires' section in features.json#29030
Open
diegomarquezp wants to merge 1 commit intomainfrom
Open
build: clear 'requires' section in features.json#29030diegomarquezp wants to merge 1 commit intomainfrom
diegomarquezp wants to merge 1 commit intomainfrom
Conversation
These files are only referenced in a test and the actual files don't exist in this repository. The jars and dependencies are all managed by the api-client BOM https://github.com/googleapis/google-api-java-client-services/blob/4ba8ff880ea4acfe490510917941a82854e47fd3/generator/tests/configuration_test.py#L125-L148
Member
|
Do you know if I'm not too sure, but it also looks like the generator's tests aren't being run? Do we have a CI job that runs the python tests? |
Contributor
|
+1 to Lawrence's question, is the test no-op now if the required section is cleared? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These files are only referenced in a test and the actual files don't exist in this repository. The jars and dependencies are all managed by the api-client BOM
google-api-java-client-services/generator/tests/configuration_test.py
Lines 125 to 148 in 4ba8ff8