chore: remove deprecated deprecation warning

[akx]

I looked through GitHub search, and it looks like no external code is referencing this deprecation warning, so I suppose it's good to go the way of the dodo post #1919.

[gemini-code-assist]

Summary of Changes

Hello @akx, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on cleaning up the codebase by removing an outdated deprecation warning. The Python37DeprecationWarning was previously used to alert users about the impending end-of-life for Python 3.7 support. As Python 3.7 is now past its end-of-life, this warning is no longer relevant, and its removal simplifies the code by eliminating dead code.

Highlights

• Code Cleanup: The Python37DeprecationWarning class has been removed from google/auth/__init__.py and google/oauth2/__init__.py.
• Deprecation Removal: This warning was for Python 3.7, which has reached its end-of-life, making the warning itself obsolete and safe to remove as confirmed by a GitHub search for external references.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes the deprecated Python37DeprecationWarning class from google/auth/__init__.py and google/oauth2/__init__.py. This is a good cleanup that improves code maintainability by removing unused code. I have one minor suggestion to improve stylistic consistency between the modified files.

[daniel-sanche]

This is not longer used internally, but technically this is part of the public API, so removing it could be a breaking change.

Users may be importing this exception to attempt to catch errors, and removing it from the codebase could cause existing code to raise exceptions

[akx]

Users may be importing this exception to attempt to catch errors, and removing it from the codebase could cause existing code to raise exceptions

As mentioned, no public code on GitHub seems to refer to this class. The only search results I can see are for vendored code of this library or other non-code references.

Also, since it's a Warning class, it's not generally raised by library code (and as such, wouldn't be caught) but invoked with warnings.warn(). The only thing I could think of is someone doing with pytest.warns(Python37DeprecationWarning) (or similar), but that seems very unlikely.

It is also not de facto part of the public API that is declared in __all__.

[daniel-sanche]

The only thing I could think of is someone doing with pytest.warns(Python37DeprecationWarning) (or similar), but that seems very unlikely.

This is the kind of thing I had in mind (or filterwarnings). There could be customers doing this kind of thing in private repositories, and removing this class would would cause their code to crash in the next release. It's GCP policy that once something is released as part of the public API, it is only ever removed in a major version upgrade, to avoid that. Even if the use-case seems uncommon

It is also not de facto part of the public API that is declared in all

I just double-checked, and it is part of the __init__.py, and I can import it with import google.auth.Python37DeprecationWarning. So unfortunately, we're stuck with this for now

Thanks for bringing this up though