Skip to content

feat(bigtable): add Clear(std::string&) helper for RowKeyType compatibility #15252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drona-gyawali wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(bigtable): add Clear(std::string&) helper for RowKeyType compatibility #15252

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1de52d9
feat(bigtable): add Clear(std::string&) helper for RowKeyType compati…
drona-gyawali Jul 7, 2025
d6cdb47
feat(bigtable): place the code after IsEmptyRowKey()
drona-gyawali Jul 8, 2025
78b644c
feat(bigtable):replace the code placement
drona-gyawali Jul 8, 2025
4fcc42d
Merge branch 'main' into add-clear-rowkey-function
scotthart Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions google/cloud/bigtable/internal/google_bytes_traits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ inline bool IsEmptyRowKey(char const* key) { return std::string{} == key; }
inline bool IsEmptyRowKey(std::string_view key) { return key.empty(); }
#endif // GOOGLE_CLOUD_CPP_CPP_VERSION >= 201703L

/// Clear the row key.
inline void Clear(std::string& key) { key.clear(); }

/// Return `< 0` if `lhs < rhs`, 0 if `lhs == rhs`, and `> 0' otherwise.
inline int CompareRowKey(std::string const& lhs, std::string const& rhs) {
return lhs.compare(rhs);
Expand Down
Loading