impl(v3): revert #15912

[scotthart]

reverts PR #15912

[gemini-code-assist]

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a complete revert of PR #15912, effectively removing the emit_completion_queue_accessor feature. This feature was designed to expose the CompletionQueue from the BackgroundThreads for specific advanced use cases. The revert simplifies the generated client code by eliminating the mechanism for generating and accessing this internal CompletionQueue via the public API, thereby removing a potentially problematic exposure of internal implementation details.

Highlights

• Revert of Feature: This pull request fully reverts the changes introduced in PR impl(v3): add generator support for connection cq access #15912, which added the emit_completion_queue_accessor feature.
• Configuration Removal: The emit_completion_queue_accessor field has been removed from generator/generator_config.proto and its corresponding configuration in generator/generator_config.textproto.
• Code Generation Logic Cleanup: All code generation logic related to the CompletionQueue accessor methods and friend functions has been removed from connection_generator.cc and connection_impl_generator.cc.
• Utility Function Removal: The HasEmitCompletionQueueAccessor utility method has been removed from service_code_generator.cc and service_code_generator.h.
• Generated Code Cleanup: Specific completion_queue related declarations and implementations have been removed from the generated BigtableTableAdmin client code.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request reverts the changes from PR #15912, which introduced the emit_completion_queue_accessor feature. The changes correctly remove all related code from the generator and the generated Bigtable admin client. The revert appears complete and correct.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.88%. Comparing base (2b9130f) to head (740c0c7).
⚠️ Report is 1 commits behind head on prepare-for-v3.0.0.

Additional details and impacted files

@@                 Coverage Diff                 @@
##           prepare-for-v3.0.0   #15913   +/-   ##
===================================================
  Coverage               92.87%   92.88%           
===================================================
  Files                    2343     2343           
  Lines                  216141   216117   -24     
===================================================
- Hits                   200734   200730    -4     
+ Misses                  15407    15387   -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.