Skip to content

Conversation

@mpeddada1
Copy link
Contributor

Cleanup as part of /438956768

Dependency management of graal-sdk is currently located in java-shared-config: https://github.com/googleapis/java-shared-config/blob/11288aa16a4be73c29b11259617f188311494013/native-image-shared-config/pom.xml#L75, making this declaration redundant.

The graal-sdk dependency is used in two places:

  1. java-spanner which uses the maven property directly: https://github.com/googleapis/java-spanner/blob/1cad02bb6648319bb5ef48d15229547b5fc52ecd/google-cloud-spanner/pom.xml#L393.
  2. cloud-sql-jdbc-socket-factory which specifies the version directly: https://github.com/GoogleCloudPlatform/cloud-sql-jdbc-socket-factory/blob/efa8bb980f205b8edb5d841929cfb8602d1573eb/pom.xml#L209.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 1, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mpeddada1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a cleanup operation by removing a duplicate dependency management entry for graal-sdk within the gax-java project. The graal-sdk dependency is already managed centrally in java-shared-config, making the local declaration in gax-java unnecessary. This change simplifies the project's pom.xml and ensures a single source of truth for this dependency's versioning.

Highlights

  • Dependency Management Cleanup: Removed the redundant dependency management entry for graal-sdk from gax-java/pom.xml.
  • Centralized Configuration: This change aligns with the existing centralized dependency management for graal-sdk already present in java-shared-config.
  • Impact on Consumers: Existing consumers like java-spanner and cloud-sql-jdbc-socket-factory will continue to resolve graal-sdk versions correctly, either through direct specification or via the shared configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the dependency management for graal-sdk from gax-java/pom.xml. As the pull request description states, this is a cleanup effort because this dependency is now managed in the parent java-shared-config project, making this declaration redundant. The change is straightforward and improves maintainability by removing this duplicated configuration. I've reviewed the change and confirmed that no modules within this repository directly depend on the org.graalvm.sdk:graal-sdk artifact, so this removal is safe. The change is correct and I approve it.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants