Draft
Conversation
This commit introduces a new "Trails" sample to the AdvancedMaps3DSamples app.
Key features and changes:
- **Trails Data Model:** Defines data classes (`Trail`, `TrailType`, `DifficultyLevel`, `DogRegulation`, `TrailStatus`) to represent trail information.
- **GeoJSON Parsing:** Implements `TrailsRepository` to read and parse GeoJSON data containing trail information. Includes logic for:
- Reading from an asset file.
- Parsing GeoJSON features, properties (including specific OSMP attributes), and LineString geometries.
- Simplifying trail coordinates using `simplify()` from `com.google.maps.android.ktx.utils`.
- Calculating the `LatLngBounds` of all trails.
- **Polyline Rendering:**
- Adds `Mappers.kt` with a `toPolylineOptions()` extension function to convert `Trail` objects into `PolylineOptions`.
- Colors polylines based on trail difficulty (Easy: Green, Moderate: Blue, Difficult: Red).
- Sets `altitudeMode` to `CLAMP_TO_GROUND` and `drawsOccludedSegments` to true.
- **Trails UI:**
- Creates `TrailsActivity`, `TrailsViewModel`, and associated composables (`MapScreen`, `LoadingScreen`).
- The `TrailsViewModel` loads trail data, creates `Map3DOptions` centered on the trails' boundary, and adds polylines to the map.
- Displays a loading indicator while data is being fetched.
- Integrates the `ThreeDMap` composable for displaying the map.
- **Common Map Composable:** Refactors `ThreeDMap.kt` from the `scenarios` package to the `common` package to be reused.
- **ViewModel Enhancements:**
- Modifies `Map3dViewModel` to use `MutableSharedFlow` with replay for `currentCamera` to ensure observers get the latest value upon subscription.
- Makes `activeMapObjects` in `Map3dViewModel` internal for access within the module.
- **MainActivity Update:** Adds the "OSMP Trails -- polyline demo" sample to the main list.
- **Manifest and Resources:** Updates `AndroidManifest.xml` to include `TrailsActivity` and adds a new string resource for the sample title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new "Trails" sample to the AdvancedMaps3DSamples app.
Key features and changes:
Trail,TrailType,DifficultyLevel,DogRegulation,TrailStatus) to represent trail information.TrailsRepositoryto read and parse GeoJSON data containing trail information. Includes logic for:simplify()fromcom.google.maps.android.ktx.utils.LatLngBoundsof all trails.Mappers.ktwith atoPolylineOptions()extension function to convertTrailobjects intoPolylineOptions.altitudeModetoCLAMP_TO_GROUNDanddrawsOccludedSegmentsto true.TrailsActivity,TrailsViewModel, and associated composables (MapScreen,LoadingScreen).TrailsViewModelloads trail data, createsMap3DOptionscentered on the trails' boundary, and adds polylines to the map.ThreeDMapcomposable for displaying the map.ThreeDMap.ktfrom thescenariospackage to thecommonpackage to be reused.Map3dViewModelto useMutableSharedFlowwith replay forcurrentCamerato ensure observers get the latest value upon subscription.activeMapObjectsinMap3dViewModelinternal for access within the module.AndroidManifest.xmlto includeTrailsActivityand adds a new string resource for the sample title.