-
Notifications
You must be signed in to change notification settings - Fork 14
feat(ENGKNOW-2766): Add gor exec commands to work with files. #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ENGKNOW-2766): Add gor exec commands to work with files. #90
Conversation
…e-state-of-reference-data-history-log
| commandListHeading = "%nCommands:%n%n", | ||
| header="GOR Command Line", | ||
| footer="%n(c) WuxiNextcode 2019") | ||
| footer="%n(c) GeneDX 2026") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: Shouldn't we compute the current year so we can guarantee this will be always correct? Something like:
using java.time.Year;
footer="%n(c) GeneDx " Year.now().getValue();
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes for this one it a good idea, I will add that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are annotations, not trivial to execute code there, I will look into this later.
cesarvp-gdx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Approved with non-blocking comment!
No description provided.