Skip to content

Conversation

@gmagnu
Copy link
Contributor

@gmagnu gmagnu commented Jan 6, 2026

No description provided.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Junit Tests - Summary

4 377 tests  ±0   4 205 ✅ ±0   10m 34s ⏱️ -10s
  460 suites +1     172 💤 ±0 
  460 files   +1       0 ❌ ±0 

Results for commit e69d2af. ± Comparison against base commit 5e657f4.

♻️ This comment has been updated with latest results.

commandListHeading = "%nCommands:%n%n",
header="GOR Command Line",
footer="%n(c) WuxiNextcode 2019")
footer="%n(c) GeneDX 2026")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Shouldn't we compute the current year so we can guarantee this will be always correct? Something like:
using java.time.Year;
footer="%n(c) GeneDx " Year.now().getValue();

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes for this one it a good idea, I will add that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are annotations, not trivial to execute code there, I will look into this later.

Copy link

@cesarvp-gdx cesarvp-gdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Approved with non-blocking comment!

@gmagnu gmagnu merged commit 605e459 into main Jan 9, 2026
11 checks passed
@gmagnu gmagnu deleted the ENGKNOW-2766-future-state-of-reference-data-history-log branch January 9, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants