fix: correct argument index usage in assignArgumentBitRatio#846
Open
ChenZhuoSteve wants to merge 1 commit intogpujs:developfrom
Open
fix: correct argument index usage in assignArgumentBitRatio#846ChenZhuoSteve wants to merge 1 commit intogpujs:developfrom
ChenZhuoSteve wants to merge 1 commit intogpujs:developfrom
Conversation
Author
|
this is only a issues if the argumentTypes parameter is declared |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: correct argument index usage in assignArgumentBitRatio
Previously, assignArgumentBitRatio incorrectly used the caller's argument index (i) to update the callee function's argumentBitRatios array. This could cause incorrect bit ratio assignment when the caller and callee functions have different argument orders. This commit fixes the bug by using the given callee argument index (argumentIndex) instead.
Added test code.