Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ private void configureJPackageArguments(ExecSpec e, Directory resourcesDir) {
private String createArgsFile(String modulePathAsPath) {
Path argsFile = getTemporaryDir().toPath().resolve("args.txt");
List<String> lines = new ArrayList<>(1);
lines.add("--module-path " + modulePathAsPath);
lines.add("--module-path \"" + modulePathAsPath.replace('\\', '/') + "\"");
try {
Files.write(argsFile, lines);
} catch (IOException e) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -189,4 +189,20 @@ void can_build_package_in_one_step() {
assertThat(build.appImageFolder().getAsPath())
.isDirectoryNotContaining(f -> f.toFile().isDirectory());
}

@Test
void works_if_module_path_contains_spaces() {
var lib2BuildFile = build.file("lib 2 with spaces/build.gradle.kts");
var lib2ModuleInfoFile = build.file("lib 2 with spaces/src/main/java/module-info.java");

build.settingsFile.appendText("""
include(":lib2")
project(":lib2").projectDir = file("lib 2 with spaces")
""");
build.appBuildFile.appendText("dependencies { implementation(project(\":lib2\")) }");
lib2BuildFile.writeText("plugins { id(\"java-library\") }");
lib2ModuleInfoFile.writeText("module org.example.libtwo { }");

build.build(":app:jpackage");
}
}