Skip to content

HCK-14918: comment custom scripts if entity is inactive #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VitaliiBedletskyi merged 3 commits into from
Feb 20, 2026
Merged

HCK-14918: comment custom scripts if entity is inactive #247

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
821fb2f
HCK-14918: comment custom scripts if entity is inactive
AlikRakhmonov Feb 20, 2026
43ba6e3
Merge branch 'develop' into HCK-14918
AlikRakhmonov Feb 20, 2026
0ecb0be
m
AlikRakhmonov Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions forward_engineering/ddlProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,10 +595,7 @@ module.exports = (baseProvider, options, app) => {
),
});
result.tableColumns.push({
name: `${getName(viewData.isCaseSensitive, key.entityName)}.${getName(
viewData.isCaseSensitive,
key.name,
)}`,
name: `${getName(viewData.isCaseSensitive, key.entityName)}.${getName(viewData.isCaseSensitive, key.name)}`,
isActivated: key.isActivated,
});

Expand Down Expand Up @@ -1048,6 +1045,10 @@ module.exports = (baseProvider, options, app) => {
return commentIfDeactivated(statement, data, isPartOfLine);
},

commentStatement(statement) {
return commentIfDeactivated(statement, { isActivated: false });
},

alterTable(data) {
if (data.iceberg) {
return '// Dynamic Iceberg tables are currently only supported for CREATE statements. Specifying DYNAMIC ICEBERG in any other command (for example, ALTER DYNAMIC ICEBERG TABLE <name>) results in an error.';
Expand Down