feat: new_lifespan to allow configuring sqla engine directly#25
Merged
feat: new_lifespan to allow configuring sqla engine directly#25
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 100 108 +8
Branches 6 7 +1
=========================================
+ Hits 100 108 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hadrien
commented
Oct 3, 2025
Owner
Author
|
@vicrep What do you think? thanks! |
|
This is great, thanks for doing this @hadrien ! I liked the 12-factor-style-config being the default recommended approach, but for some specific setups, and nested config args (eg. that reported issue), the ergonomics of doing it fully through environ were at times lacking. |
|
Super nice, thank you for the quick fix! |
hadrien
added a commit
that referenced
this pull request
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
connect_argswith environment variablesSolution
new_lifespanto allow passing sqla engine parameters directly: