Make InitializeRequestArguments follow the protocol#18
Conversation
It was previously making too many fields required and missing the supportsANSIStyling property Fixes #17
dmjio
left a comment
There was a problem hiding this comment.
Nice find w/ supportsANSIStyling, and yes the nullability is off. Well done. Might be worth it to make smart constructors, with Nothing defaults, but we could probably do in a separate pass.
|
I don't think smart constructors would help library users that much, just add indirection. Typically you're using the library to receive InitalizeRequestArguments in which case you probably do want to deal with the |
|
Yea, that's a good point, we're receiving not constructing, maybe only for testing it would be relevant then. |
It was previously making too many fields required and missing the
supportsANSIStylingpropertyFixes #17