Skip to content

v2.6.13: 修复app端接口判断本子不存在逻辑,actions教程添加图片#512

Merged
hect0x7 merged 3 commits intomasterfrom
dev
Feb 3, 2026
Merged

v2.6.13: 修复app端接口判断本子不存在逻辑,actions教程添加图片#512
hect0x7 merged 3 commits intomasterfrom
dev

Conversation

@hect0x7
Copy link
Owner

@hect0x7 hect0x7 commented Feb 3, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Stricter validation to avoid missing-data responses when fetching album/details.
  • Documentation

    • Added a top banner image to the tutorial for improved presentation.
  • Chores

    • Project version bumped to 2.6.13.
  • Tests

    • Added ranking test and updated tests for missing-album and detail-property validations.

@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

Bumps package version to 2.6.13, requires non-empty resp.encoded_data in fetch_detail_entity, adds a new test test_ranking and adjusts a missing-album test ID, and inserts a banner image into a tutorial Markdown file.

Changes

Cohort / File(s) Summary
Documentation
assets/docs/sources/tutorial/1_github_actions.md
Inserted a top banner image and added surrounding blank lines for spacing (presentation change only).
Version Bump
src/jmcomic/__init__.py
Updated __version__ from '2.6.12' to '2.6.13'.
Client Validation
src/jmcomic/jm_client_impl.py
Added an extra guard in fetch_detail_entity to require non-empty resp.encoded_data alongside the existing name check; raises missing-response when absent.
Tests
tests/test_jmcomic/test_jm_client.py
Added test_ranking; changed test_album_missing to assert missing album for ID 530595; expanded/added docstrings for some tests.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Dev #326 — modifies fetch_detail_entity error-handling/validation (same guard logic area).
  • Dev #510 — previously bumped __version__ in src/jmcomic/__init__.py (related version changes).
  • v2.5.33: 更新禁漫API域名 #399 — also updates package version constant (__version__) in the same module.

Poem

🐰 I hopped through code with gentle cheer,
I nudged a guard so data's near,
A version bumped, a test to sing,
A banner placed — a tiny spring,
Hop, hop, we ship with carrot-tinged cheer! 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 57.14% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: version bump to 2.6.13, a fix for app API logic detecting missing albums, and adding an image to the GitHub Actions tutorial.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

Note

Docstrings generation - SUCCESS
Generated docstrings for this pull request at #513

coderabbitai bot added a commit that referenced this pull request Feb 3, 2026
Docstrings generation was requested by @hect0x7.

* #512 (comment)

The following files were modified:

* `src/jmcomic/jm_client_impl.py`
* `tests/test_jmcomic/test_jm_client.py`
@coderabbitai coderabbitai bot mentioned this pull request Feb 3, 2026
coderabbitai bot and others added 2 commits February 3, 2026 22:41
Docstrings generation was requested by @hect0x7.

* #512 (comment)

The following files were modified:

* `src/jmcomic/jm_client_impl.py`
* `tests/test_jmcomic/test_jm_client.py`

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@hect0x7 hect0x7 merged commit 620a094 into master Feb 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant