Implement music attenuation for Linux #1718
Open
+273
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds music attenuation support for Linux using the D-Bus API. This is done by iterating through every server which implements org.mpris.MediaPlayer2 and using its PlaybackStatus (through org.freedesktop.DBus.Properties) to determine if it is playing.
To be transparent, I don't really have much experience with pull requests and because I didn't spot the other PR (#1117) for this feature until I had already done the bulk of the work on my version, I didn't really know whether to submit this or not. I've noticed that #1117 hasn't made any progress in nearly a year, so I figured I would at least like to get the ball rolling again on getting this feature merged.