Skip to content

[Snyk] Fix for 4 vulnerabilities #11892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 4 vulnerabilities #11892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/techdocs-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,11 @@
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-search-backend-module-techdocs": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-techdocs-node": "workspace:^",
"@backstage/plugin-search-backend-module-techdocs": "0.2.0",
"@backstage/plugin-search-common": "0.3.1",
"@backstage/plugin-techdocs-node": "1.13.11",
Comment on lines +58 to +62
Copy link

@gemini-code-assist gemini-code-assist bot Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes are incorrect and will likely break the application.

  1. Incorrect Version Pinning: This PR replaces workspace:^ with pinned versions. In a Yarn workspace monorepo, this is generally incorrect as it breaks the linkage between local packages.
  2. Major Downgrades: The versions for @backstage/plugin-catalog-common (1.0.15 in workspace -> 0.1.0) and @backstage/plugin-search-common (1.2.5 in workspace -> 0.3.1) are significant downgrades. This will likely lead to build failures or runtime errors due to API incompatibilities.
  3. Tooling Failure: The PR description explicitly states Failed to update the yarn.lock, please update manually before merging.. This is a strong indicator that the dependency resolution failed and the suggested versions are not compatible.

Instead of applying these changes, the vulnerabilities should be addressed by updating the source packages within the monorepo if necessary, and then running yarn to update the lockfile. I suggest reverting these changes.

    "@backstage/plugin-catalog-common": "workspace:^",
    "@backstage/plugin-permission-common": "workspace:^",
    "@backstage/plugin-search-backend-module-techdocs": "workspace:^",
    "@backstage/plugin-search-common": "workspace:^",
    "@backstage/plugin-techdocs-node": "workspace:^"

"@types/express": "^4.17.6",
"dockerode": "^3.3.1",
"express": "^4.17.1",
Expand Down
Loading