Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/graphql-backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@apollo/server": "^4.0.0",
"@backstage/backend-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-catalog-graphql": "workspace:^",
"@apollo/server": "^5.4.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This is a major version upgrade for @apollo/server from v4 to v5. This likely includes breaking changes that will require code modifications. Please consult the official migration guide and update your implementation accordingly.

"@backstage/backend-common": "0.24.1",
"@backstage/config": "0.1.1",
"@backstage/plugin-catalog-graphql": "0.1.1",
Comment on lines +37 to +39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Replacing workspace:^ with pinned versions breaks the monorepo structure. This change is particularly problematic as it appears to be downgrading @backstage/config (from 1.0.8 to 0.1.1) and @backstage/plugin-catalog-graphql (from 0.3.22 to 0.1.1). This will likely lead to build failures or runtime errors.

It's recommended to keep the workspace:^ specifier to ensure local packages are used. To fix the vulnerabilities, the dependencies within the respective workspace packages should be updated, and then yarn install should be run to update the yarn.lock file.

    "@backstage/backend-common": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/plugin-catalog-graphql": "workspace:^"

"@graphql-tools/schema": "^9.0.0",
"@types/express": "^4.17.6",
"express": "^4.17.1",
Expand Down
Loading