Fix DDIMScheduler.step() prev_timestep for non-leading spacing#13108
Open
Mr-Neutr0n wants to merge 1 commit intohuggingface:mainfrom
Open
Fix DDIMScheduler.step() prev_timestep for non-leading spacing#13108Mr-Neutr0n wants to merge 1 commit intohuggingface:mainfrom
Mr-Neutr0n wants to merge 1 commit intohuggingface:mainfrom
Conversation
When timestep_spacing is set to 'linspace' or 'trailing', the formula timestep - num_train_timesteps // num_inference_steps does not produce the correct previous timestep. Use a lookup into self.timesteps instead, matching the approach used in DDPMScheduler.previous_timestep().
Author
|
Friendly bump! Let me know if there's anything I should update or improve to help move this forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DDIMScheduler.step()to correctly computeprev_timestepwhentimestep_spacingis set tolinspaceortrailingtimestep - num_train_timesteps // num_inference_steps) that only produces correct values fortimestep_spacing="leading"previous_timestep()method that looks up the next timestep fromself.timesteps, consistent with the approach already used inDDPMSchedulerFixes #12633
Test plan
timestep_spacing="linspace"timestep_spacing="trailing"timestep_spacing="leading"