Fix SanaCombinedTimestepGuidanceEmbeddings to handle missing guidance#13109
Open
Mr-Neutr0n wants to merge 1 commit intohuggingface:mainfrom
Open
Fix SanaCombinedTimestepGuidanceEmbeddings to handle missing guidance#13109Mr-Neutr0n wants to merge 1 commit intohuggingface:mainfrom
Mr-Neutr0n wants to merge 1 commit intohuggingface:mainfrom
Conversation
When guidance_embeds=True but guidance is not provided at inference time, SanaCombinedTimestepGuidanceEmbeddings.forward() would crash because it tried to project None through the guidance condition projector. Default to ones_like(timestep) when guidance is None, and accept **kwargs for forward compatibility with callers that pass batch_size.
Author
|
Friendly bump! Let me know if there's anything I should update or improve to help move this forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SanaCombinedTimestepGuidanceEmbeddings.forward()to handle the case whereguidanceisNoneguidance_embeds=Truebutguidanceis not provided at inference time, the forward call would crash trying to projectNonethrough the guidance condition projectorones_like(timestep)when guidance is not provided**kwargsfor forward compatibility with callers that passbatch_sizeFixes #12540
Test plan
guidance_embeds=Trueand no guidance provided