Add bounds check for AuraFlow positional embedding indices#13110
Open
Mr-Neutr0n wants to merge 1 commit intohuggingface:mainfrom
Open
Add bounds check for AuraFlow positional embedding indices#13110Mr-Neutr0n wants to merge 1 commit intohuggingface:mainfrom
Mr-Neutr0n wants to merge 1 commit intohuggingface:mainfrom
Conversation
When the input latent spatial dimensions exceed the positional embedding grid size, the centered-crop index calculation produces negative or out-of-range indices. This causes a fatal CUDA assertion error that destroys the CUDA context for the entire process. Add an explicit check that raises a clear ValueError instead of silently producing invalid indices.
Author
|
Friendly bump! Let me know if there's anything I should update or improve to help move this forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AuraFlowPatchEmbed.pe_selection_index_based_on_dim()to prevent out-of-bounds positional embedding indicesind >= 0 && ind < ind_dim_size) that destroys the CUDA context for the entire processValueErrorwith guidance on how to fix the issue, instead of silently producing invalid indicesFixes #12656
Test plan